-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(core): add start and end time to post hook #32583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Command | Status | Duration | Result |
---|---|---|---|
nx affected --targets=lint,test,build,e2e,e2e-c... |
✅ Succeeded | 42m 4s | View ↗ |
nx run-many -t check-imports check-commit check... |
✅ Succeeded | 1m 54s | View ↗ |
nx-cloud record -- nx-cloud conformance:check |
✅ Succeeded | 2s | View ↗ |
nx-cloud record -- nx format:check |
✅ Succeeded | 4s | View ↗ |
nx-cloud record -- nx sync:check |
✅ Succeeded | 4s | View ↗ |
nx documentation |
✅ Succeeded | 2m 40s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-09-02 09:44:26
UTC
@@ -1,5 +1,5 @@ | |||
import type { ProjectGraph } from '../../config/project-graph'; | |||
import { readNxJson, type PluginConfiguration } from '../../config/nx-json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are unused
@@ -22,14 +22,6 @@ export interface TaskMetadata { | |||
groupId: number; | |||
} | |||
|
|||
interface RustRunningTask extends RunningTask { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very easy to get if users run Date.now()
in their pre and post hooks. I don't think we need to be the one providing this.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #