Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Sep 2, 2025
@meeroslav meeroslav requested a review from a team as a code owner September 2, 2025 08:53
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 2, 2025 8:53am

@meeroslav meeroslav changed the title feat(core): add start and end time to post hook and fix docs feat(core): add start and end time to post hook Sep 2, 2025
Copy link
Contributor

nx-cloud bot commented Sep 2, 2025

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 973825d

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 42m 4s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 54s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 2m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-02 09:44:26 UTC

@@ -1,5 +1,5 @@
import type { ProjectGraph } from '../../config/project-graph';
import { readNxJson, type PluginConfiguration } from '../../config/nx-json';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unused

@@ -22,14 +22,6 @@ export interface TaskMetadata {
groupId: number;
}

interface RustRunningTask extends RunningTask {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused

@meeroslav meeroslav added the scope: core core nx functionality label Sep 8, 2025
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very easy to get if users run Date.now() in their pre and post hooks. I don't think we need to be the one providing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants