fix(js): adjusted stdout and stderr handling to support the latest @swc/cli version #32685
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| await postCompilationCallback(); | ||
| initialPostCompile = false; | ||
| handleCallback = async (type: string, data?: string) => { | ||
| if (type === 'stdout' || data.includes('Successfully')) { |
There was a problem hiding this comment.
The condition type === 'stdout' || data.includes('Successfully') creates a logical issue where stderr output containing "Successfully" would be processed as stdout data. This could cause error messages to be misinterpreted as success indicators.
Consider restructuring the condition to first check the stream type, then check the content:
if (type === 'stdout') {
// Process stdout data
process.stdout.write(data);
if (data.includes('Successfully')) {
// Handle success case
}
} else if (type === 'stderr') {
// Process stderr data appropriately
}This would maintain proper separation between stdout and stderr handling while still detecting success messages.
| if (type === 'stdout' || data.includes('Successfully')) { | |
| if (type === 'stdout') { | |
| process.stdout.write(data); | |
| if (data.includes('Successfully')) { | |
| // Handle success case | |
| } | |
| } else if (type === 'stderr') { | |
| // Process stderr data appropriately | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| await postCompilationCallback(); | ||
| initialPostCompile = false; | ||
| handleCallback = async (type: string, data?: string) => { | ||
| if (type === 'stdout' || data.includes('Successfully')) { |
There was a problem hiding this comment.
There's a potential issue with the conditional logic in this line. If data is undefined, calling data.includes('Successfully') will throw an error. Consider adding a null check to prevent runtime errors:
if (type === 'stdout' || (data && data.includes('Successfully'))) {This ensures the code safely handles cases where data might be undefined or null.
| if (type === 'stdout' || data.includes('Successfully')) { | |
| if (type === 'stdout' || (data && data.includes('Successfully'))) { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Current Behavior
Due to this PR swc-project/pkgs#53 at SWC, it is not possible to use the latest version of @swc/cli in NX.
Expected Behavior
stdout and stderr are now handled more precisely, allowing you to update to the latest version of @swc/cli.