feat(core): add {userHome} token support for external outputs #32693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable outputs outside workspace using {userHome} token syntax.
Users can now specify outputs like {userHome}/builds/{projectName}
to place build artifacts in their home directory or other external
locations while maintaining full Nx caching functionality.
Key changes:
- Add cross-platform home directory resolution in Rust
- Extend output validation to accept {userHome} prefix
- Update output expansion to handle absolute paths
- Enhance TypeScript interpolation with userHome support
- Add comprehensive test coverage
Fixes #31568, #5433, #11156
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 88fce07
☁️ Nx Cloud last updated this comment at |
Comment on lines
+346
to
+348
| !interpolatedOutput.match( | ||
| /{(projectRoot|workspaceRoot|userHome|(options.*))}/ | ||
| ) |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements
{userHome}token support for Nx outputs, enabling users to specify output directories relative to their home directory. This solves the long-standing issue where Nx couldn't properly cache outputs placed outside the workspace.Key Features
{userHome}token pattern{workspaceRoot}and{projectRoot}tokens unchangedUsage Examples
{ "targets": { "build": { "executor": "@nx/webpack:webpack", "outputs": [ "{userHome}/shared-builds/{projectName}", "{userHome}/Desktop/deployments" ], "options": { "outputPath": "{userHome}/shared-builds/{projectName}" } } } }Implementation Details
Rust Core Changes
home_dir.rsutility for cross-platform home directory resolution{userHome}and!{userHome}prefixesexpand_outputs()andget_files_for_outputs()to handle absolute pathsresolve_user_home_tokens()function for token replacementTypeScript Integration
userHome: homedir()to interpolation data{userHome}tokenTest Coverage
Test plan
Fixes #31568, #5433, #11156
Type of change
🤖 Generated with Claude Code