-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): add parallel steps to agents.yaml #32705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit 8262924
☁️ Nx Cloud last updated this comment at |
df442ec
to
1fb3160
Compare
1fb3160
to
5311241
Compare
.nx/workflows/agents.yaml
Outdated
sudo apt-get update - name: Install zip and unzip | ||
- name: Install zip and unzip for Bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a formatting error in this section. The apt-get update
command and the next step definition are incorrectly merged on the same line:
sudo apt-get update - name: Install zip and unzip
This should be separated into two distinct lines:
sudo apt-get update
- name: Install zip and unzip
This syntax error would cause the workflow to fail when executed.
sudo apt-get update - name: Install zip and unzip | |
- name: Install zip and unzip for Bun | |
sudo apt-get update | |
- name: Install zip and unzip | |
- name: Install zip and unzip for Bun |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
5311241
to
d13b4bf
Compare
.nx/workflows/agents.yaml
Outdated
source /home/workflows/.bashrc | ||
bun --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of source /home/workflows/.bashrc
introduces a dependency on a specific environment file that wasn't present in the original implementation. This change could potentially cause failures if the file doesn't exist or contains unexpected commands. For consistency and reliability, consider keeping just the bun --version
command as it was originally implemented, which should work correctly since Bun was already added to the PATH in previous steps.
source /home/workflows/.bashrc | |
bun --version | |
bun --version |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
d13b4bf
to
8262924
Compare
Current Behavior
Expected Behavior
Moved common init steps and envs into variables. Applied parallelism to steps that can complete concurrently.
Related Issue(s)
Fixes #