Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

lourw
Copy link
Contributor

@lourw lourw commented Sep 11, 2025

Current Behavior

Expected Behavior

Moved common init steps and envs into variables. Applied parallelism to steps that can complete concurrently.

Related Issue(s)

Fixes #

@lourw lourw requested a review from a team as a code owner September 11, 2025 17:04
@lourw lourw requested a review from AgentEnder September 11, 2025 17:04
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 11, 2025 5:53pm

Copy link
Contributor

nx-cloud bot commented Sep 11, 2025

View your CI Pipeline Execution ↗ for commit 8262924

Command Status Duration Result
nx documentation ⛔ Cancelled 1m 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-11 17:38:31 UTC

@lourw lourw force-pushed the lourw/update-agents-yaml branch from df442ec to 1fb3160 Compare September 11, 2025 17:09
@lourw lourw force-pushed the lourw/update-agents-yaml branch from 1fb3160 to 5311241 Compare September 11, 2025 17:20
Comment on lines 24 to 25
sudo apt-get update - name: Install zip and unzip
- name: Install zip and unzip for Bun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a formatting error in this section. The apt-get update command and the next step definition are incorrectly merged on the same line:

sudo apt-get update      - name: Install zip and unzip

This should be separated into two distinct lines:

sudo apt-get update
- name: Install zip and unzip

This syntax error would cause the workflow to fail when executed.

Suggested change
sudo apt-get update - name: Install zip and unzip
- name: Install zip and unzip for Bun
sudo apt-get update
- name: Install zip and unzip
- name: Install zip and unzip for Bun

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@lourw lourw force-pushed the lourw/update-agents-yaml branch from 5311241 to d13b4bf Compare September 11, 2025 17:22
source /home/workflows/.bashrc
bun --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of source /home/workflows/.bashrc introduces a dependency on a specific environment file that wasn't present in the original implementation. This change could potentially cause failures if the file doesn't exist or contains unexpected commands. For consistency and reliability, consider keeping just the bun --version command as it was originally implemented, which should work correctly since Bun was already added to the PATH in previous steps.

Suggested change
source /home/workflows/.bashrc
bun --version
bun --version

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant