fix(core): swc register base url missing when using tsgo #33332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coly010
approved these changes
Dec 12, 2025
With the new tsgo `baseUrl` has been completely removed, this breaks compilation of plugins using swc when calling them with nx due to swc needing the baseUrl. I patched my company workspace with this fix and it did resolve it, not sure if its the right fix or what the ramifications are so happy to discuss that more. Since `baseUrl` is removed in tsgo (and recommended against in general), we need to find a way to provide it to swc (potentially through an `.swcrc` alternatively, I tried adding that to my workspace though and it didn't do anything).
acefeb8 to
dc1381d
Compare
Contributor
|
View your CI Pipeline Execution ↗ for commit dc1381d
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Dec 12, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> With the new tsgo `baseUrl` has been completely removed, this breaks compilation of plugins using swc when calling them with nx due to swc needing the baseUrl. I patched my company workspace with this fix and it did resolve it, not sure if its the right fix or what the ramifications are so happy to discuss that more. Since `baseUrl` is removed in tsgo (and recommended against in general), we need to find a way to provide it to swc (potentially through an `.swcrc` alternatively, I tried adding that to my workspace though and it didn't do anything). ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
With the new tsgo
baseUrlhas been completely removed, this breaks compilation of plugins using swc when calling them with nx due to swc needing the baseUrl. I patched my company workspace with this fix and it did resolve it, not sure if its the right fix or what the ramifications are so happy to discuss that more. SincebaseUrlis removed in tsgo (and recommended against in general), we need to find a way to provide it to swc (potentially through an.swcrcalternatively, I tried adding that to my workspace though and it didn't do anything).Expected Behavior
Related Issue(s)
Fixes #