cleanup, fixes and restructure #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache some informations for better access auto set filteres block ranges when updating options known issues: everything updates if any option changes, even if it's not related to the font the filters are applied in PopulateSupportedCharacters() sometimes there's still another font displayed (e.g. the latin characters in the google icon font are from Roboto?!)
implement lazy evaluation of font measuring by making their data optional and private with getters which do the evaluation on demand
…t (as the lazy loading may introduce hitches on slow systems)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the options post property changed delegate is now one function which repopulates the character list and the grid panels (instead of each grid panel doing it's own thing)
filtering is now done on options change (this was just more convenient to do for me right now, and it skips the measurement calculation when it's not necessary)
most things which are tied to a specific range are now in a TMap<EUnicodeBlockRange, foobar> for easier access
When changing options/font it now picks the ranges based on the Ranges which have entries (this hides all empty categories by default)
todo: the PostPropertyChanged delegate should probably be a bit smarter and only repopulate characters when the font/filter changes