chore: support Python 3.12 #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avik Basu <[email protected]>
Signed-off-by: Avik Basu <[email protected]>
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 52 52
Lines 2002 2002
Branches 119 119
=======================================
Hits 1895 1895
Misses 78 78
Partials 29 29 ☔ View full report in Codecov by Sentry. |
vigith
approved these changes
May 8, 2024
kohlisid
approved these changes
May 8, 2024
|
Have we tested end to end manually/through test once to ensure everything good? |
I tested a cat container locally. But let's test it once before we create a release. Anyway, this should not affect previous python versions. Can you take that up @kohlisid ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 support