Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ab93
Copy link
Member

@ab93 ab93 commented May 30, 2024

No description provided.

@ab93 ab93 self-assigned this May 30, 2024
@ab93 ab93 marked this pull request as ready for review May 30, 2024 22:36
@ab93 ab93 requested review from vigith and whynowy as code owners May 30, 2024 22:36
@ab93 ab93 requested review from kohlisid and removed request for vigith and whynowy May 30, 2024 22:36
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (20aa1fd) to head (0493d9c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          52       52           
  Lines        2002     2002           
  Branches      119      119           
=======================================
  Hits         1895     1895           
  Misses         78       78           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already added here: https://github.com/numaproj/numaflow-python/pull/166/files

If you check the tests, you can find 3.12 run also

@ab93 ab93 merged commit ffe7230 into main May 30, 2024
@ab93 ab93 deleted the bump-version branch May 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants