-
Notifications
You must be signed in to change notification settings - Fork 24
fix: modify Dockerfiles to fix failing image builds #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 52 52
Lines 2003 2003
Branches 119 119
=======================================
Hits 1896 1896
Misses 78 78
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Signed-off-by: a3hadi <[email protected]>
…thon into fix-image-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these dockerfile examples are non optimized. We should comeback later to fix them
@ayildirim21 Tested with images running? |
Signed-off-by: a3hadi <[email protected]>
I ran several of the example pipelines locally, after pushing their respective images, and did not come across any errors in the container logs |
@ayildirim21 Please do verify both approaches once, default and with args in the yaml |
@kohlisid Ran the
Present and not, both pipelines ran fine |
Thanks @ayildirim21 |
Kindly explain what this PR does.