Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ayildirim21
Copy link
Member

Kindly explain what this PR does.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (b847504) to head (2599b18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          52       52           
  Lines        2003     2003           
  Branches      119      119           
=======================================
  Hits         1896     1896           
  Misses         78       78           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these dockerfile examples are non optimized. We should comeback later to fix them

@kohlisid
Copy link
Contributor

@ayildirim21 Tested with images running?

@ayildirim21
Copy link
Member Author

ayildirim21 commented Jul 12, 2024

@ayildirim21 Tested with images running?

I ran several of the example pipelines locally, after pushing their respective images, and did not come across any errors in the container logs

@kohlisid
Copy link
Contributor

kohlisid commented Jul 12, 2024

@ayildirim21 Please do verify both approaches once, default and with args in the yaml
Thanks!

@ayildirim21
Copy link
Member Author

ayildirim21 commented Jul 12, 2024

@kohlisid Ran the even-odd example with both

container:
  args:
  - python
  - example.py

Present and not, both pipelines ran fine

@kohlisid
Copy link
Contributor

Thanks @ayildirim21

@kohlisid kohlisid merged commit 61195e5 into numaproj:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants