Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: update batchmap and mapstream to use Map proto #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 6, 2024
Merged

feat: update batchmap and mapstream to use Map proto #200

merged 5 commits into from
Nov 6, 2024

Conversation

kohlisid
Copy link
Contributor

@kohlisid kohlisid commented Nov 1, 2024

Kindly explain what this PR does.

@kohlisid
feat: unify batchmap
09748a3 
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid changed the title feat: unify batchmap feat: unify batchmap to use Map proto Nov 1, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.13%. Comparing base (688132a) to head (7ba064d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pynumaflow/mapstreamer/servicer/async_servicer.py 86.66% 0 Missing and 2 partials ⚠️
pynumaflow/batchmapper/servicer/async_servicer.py 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   94.16%   94.13%   -0.04%     
==========================================
  Files          55       55              
  Lines        2313     2317       +4     
  Branches      153      155       +2     
==========================================
+ Hits         2178     2181       +3     
  Misses         99       99              
- Partials       36       37       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kohlisid
chore: mapstream
0df077f 
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid changed the title feat: unify batchmap to use Map proto feat: unify batchmap and mapstream to use Map proto Nov 6, 2024
@kohlisid kohlisid changed the title feat: unify batchmap and mapstream to use Map proto feat: update batchmap and mapstream to use Map proto Nov 6, 2024
@vigith vigith marked this pull request as ready for review November 6, 2024 17:30
@kohlisid
Copy link
Contributor Author

kohlisid commented Nov 6, 2024 

    e2e_suite.go:157: Redis resources are deleted
--- PASS: TestMapSuite (200.10s)
    --- PASS: TestMapSuite/TestMapStreamUDFunctionAndSink (165.09s)
PASS
ok      github.com/numaproj/numaflow/test/map-e2e       201.036s

@kohlisid
chore: clean
7ba064d 
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid
Copy link
Contributor Author

kohlisid commented Nov 6, 2024 


    e2e_suite.go:157: Redis resources are deleted
--- PASS: TestMapSuite (133.92s)
    --- PASS: TestMapSuite/TestBatchMapUDFunctionAndSink (108.23s)
PASS
ok      github.com/numaproj/numaflow/test/map-e2e       134.844s

@kohlisid kohlisid merged commit f2f7bf6 into numaproj:main Nov 6, 2024
11 checks passed
@kohlisid kohlisid deleted the batch-map branch November 6, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@ab93 ab93 Awaiting requested review from ab93 ab93 is a code owner

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kohlisid @vigith