Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add icon to indicate capture with caption #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

feat: add icon to indicate capture with caption #1506

merged 1 commit into from
Apr 14, 2022

Conversation

sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Apr 4, 2022 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sultanmyrza
Copy link
Contributor Author

Current implementation looks like this (demo).
The current, implementation has 2 Issues!

  1. (Not reactive) With the current implementation users always need to refresh the page to see if the caption icon is updated.
  2. (Not optimal) for every item I call diaBackendAssetRepository.fetchByProof$ to get DiaBackendAsset and then I get the caption aka map(asset => asset.caption !== '')

Is there a better way to get a caption for capture?

@sync-by-unito sync-by-unito bot mentioned this pull request Apr 4, 2022
Closed
shc261392
shc261392 approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current approach is acceptable so I'll accept this pull request. We can optimize it further in the future.

@shc261392 shc261392 merged commit 9f1b99c into numbersprotocol:develop Apr 14, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shc261392 shc261392 shc261392 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sultanmyrza @shc261392