Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: Scalar type constructors take arbitrary kwargs then ignore them #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eric-wieser opened this issue Jun 11, 2018 · 3 comments · Fixed by #15446
Closed

BUG: Scalar type constructors take arbitrary kwargs then ignore them #11304

eric-wieser opened this issue Jun 11, 2018 · 3 comments · Fixed by #15446
Labels
00 - Bug component: numpy._core defunct — difficulty: Intermediate

Comments

@eric-wieser
Copy link
Member

@name@_arrtype_new has kwds, but uses PyArg_ParseTuple instead of PyArg_ParseTupleAndKeywords, which means that arbitrary keywords are accepted then ignored

Cause of #11302
@eric-wieser eric-wieser mentioned this issue Jun 11, 2018
Closed
@ezhang887
Copy link

@eric-wieser Is this still up for grabs?

@eric-wieser
Copy link
Member Author

Open issues should always be assumed up for grabs :)

@ezhang887
Copy link

ezhang887 commented Jul 4, 2018 •
edited
Loading

@eric-wieser Is this just changing the call and arguments here?

Also, do you have a list of the keywords?

@bmakos bmakos mentioned this issue Nov 15, 2018
Merged
eric-wieser added a commit to eric-wieser/numpy that referenced this issue Jan 27, 2020
@eric-wieser
BUG: Reject nonsense arguments to scalar constructors
b7cbf64 
Fixes numpy#11304
@eric-wieser eric-wieser mentioned this issue Jan 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug component: numpy._core defunct — difficulty: Intermediate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Reject nonsense arguments to scalar constructors eric-wieser/numpy
3 participants
@eric-wieser @mattip @ezhang887