Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Finish deprecation cycle for comparison to NaT #11945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoyer opened this issue Sep 13, 2018 · 2 comments
Closed

Finish deprecation cycle for comparison to NaT #11945

shoyer opened this issue Sep 13, 2018 · 2 comments
Milestone
1.16.0 release

Comments

@shoyer
Copy link
Member

shoyer commented Sep 13, 2018

xref #7019

We started this deprecation cycle with NumPy 1.11 back in March, 2016. At the time, it was suggested we would change the behavior for NumPy 1.13, but that's passed by now.

Let's try not to forget it for the 1.16 release? :)
@charris charris added this to the 1.16.0 release milestone Sep 13, 2018
@charris
Copy link
Member

charris commented Sep 14, 2018

Want to make a PR?

shoyer added a commit to shoyer/numpy that referenced this issue Sep 14, 2018
@shoyer
DEP: finish making all comparisons to NaT false
98916bb 
Closes numpygh-11945
@shoyer shoyer mentioned this issue Sep 14, 2018
Merged
@shoyer
Copy link
Member Author

shoyer commented Sep 14, 2018

OK, see #11948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.0 release
Development

No branches or pull requests
2 participants
@charris @shoyer