-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Building on windows no longer works #12411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What's different on your machine vs. the passing builds in our Azure CI matrix? |
Probably the installation paths. My hunch is that MSVC is now receiving extra quotes, due to Basically, |
https://bugs.python.org/issue8987 is related here, but it looks like distutils is destined to be broken forever, for fear of breaking people who are working around the bugs. |
Removing our patch to |
After the recent patch to CCompiler.spawn, the file-paths no longer need manual quoting - that's handled as needed within subprocess. Fixes numpy#12411
Uh oh!
There was an error while loading. Please reload this page.
Bisected to b18d0a5 (#11898). Output on my machine, at 1466e78:
The text was updated successfully, but these errors were encountered: