DEP: remove untested, non-numeric code #12541
Labels
Comments
|
This would require deprecating |
|
@mattip I've got some time to contribute at the moment. I'd need some guidance on how to get started (I don't have problems building/testing NumPy, only context on this specific issue) |
|
You can look at other API function deprecations, like in #21188 here. Note this needs a release note, see the readme |
seberg
added a commit
to seberg/numpy
that referenced
this issue
Nov 21, 2022
We do not use these in NumPy anymore, and at this point the whole `npy_interrupt.h` header only exists in case someone is using it out there. We may wish to just remove it at some point, vendoring the header is simple enough after all (and no known downstream usage exists). See also numpygh-7545, numpygh-12541
This was referenced Nov 21, 2022
|
This is gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In trying to make sense of our header files, I noticed we have a
npy_interrupt.hfile that defines a way to allow C code to respond to interrupts. The code is not tested. The only place it is used internally is inint_asbuffer, which interprets a python int as a pointer to a block of memory, tries to determine the size of the block, and returns a buffer object. It also is not tested.At some point we should remove these since they are not really part of NumPy.
The text was updated successfully, but these errors were encountered: