Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC/DEP: Document and/or deprecate uint0 and int0 #15334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rubix982 opened this issue Jan 15, 2020 · 6 comments
Closed

DOC/DEP: Document and/or deprecate uint0 and int0 #15334

Rubix982 opened this issue Jan 15, 2020 · 6 comments
Labels
04 - Documentation

Comments

@Rubix982
Copy link

Rubix982 commented Jan 15, 2020 •
edited by seberg
Loading

Hi.

The page at https://numpy.org/devdocs/user/basics.types.html does not include a valid data type in numpy, that is, int0.
Request to edit the datatype into the doc.

<------ reproducing code example ------>

>>> import numpy as np
>>> np.int0 is np.int64
True
>>> np.__version__
'1.81.1'
>>> exit()

After exiting

[user@linux~]$ python --version
Python 3.8.1

The code example is provided thanks to user 'Right leg' from here,
https://stackoverflow.com/questions/48350693/what-is-numpy-method-int0 .

Thank you.

EDIT by seberg: In gh-11025 Robert notes that "In Numeric, Int0 is indeed equivalent to Int8" if this is documented, we have to make sure to be correct as to whether this is an alias to intp or to int8.
@eric-wieser
Copy link
Member

Related: #11025

@seberg seberg changed the title Please include int0 in the documentation, at https://numpy.org/devdocs/user/basics.types.html DOC/DEP: Document and/or deprecate uint0 and int0 Jan 15, 2020
@seberg
Copy link
Member

seberg commented Jan 15, 2020

Well, I will not oppose to adding it to the documentation, but only if it reads: deprecated clearly. We should deprecate them in code as well, but that is only reasonable in 3.7+, so for now I am not quite sure (but I would definitely merge a PR proposing it :)).

@seberg seberg mentioned this issue Jan 15, 2020
Closed
@Rubix982
Copy link
Author

Rubix982 commented Jan 15, 2020 •
edited
Loading

@seberg

I would be happy to make the PR.
Where can I find it in this repository?
Sorry, I'm completely new to this kind of stuff - merging and PRs.

@eric-wieser
Copy link
Member

We should deprecate them in code as well, but that is only reasonable in 3.7+

We should probably focus on writing the NEP for #14901 before we try and deprecate anything else like it.

@Rubix982
Copy link
Author

@eric-wieser alright, I'll keep this issue open till then.

@ogrisel ogrisel mentioned this issue Nov 25, 2022
Closed
@seberg
Copy link
Member

seberg commented Jan 28, 2024

Those odd alias (int0, etc.) are finally all gone.

@seberg seberg closed this as completed Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
04 - Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seberg @eric-wieser @Rubix982