Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update PyPI classifiers to not install with unsupported Python versions #17349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rgommers opened this issue Sep 18, 2020 · 4 comments · Fixed by #17443
Closed

update PyPI classifiers to not install with unsupported Python versions #17349

rgommers opened this issue Sep 18, 2020 · 4 comments · Fixed by #17443
Assignees
@rgommers
Labels
component: distribution

Comments

@rgommers
Copy link
Member

rgommers commented Sep 18, 2020 •
edited
Loading

Right now if you do pip-3.9 install numpy, it will try to build NumPy for a version that does not support Python 3.9 yet (as stated in the release notes, and in numpy/__init__.py). We should see if we can fix the PyPI classifiers for this.

EDIT: or it's python_requires='>=3.6' in setup.py.
@rgommers rgommers self-assigned this Sep 18, 2020
@eric-wieser
Copy link
Member

It's definitely python_requires that's relevant.

@hugovk
Copy link
Contributor

hugovk commented Sep 28, 2020

Do you mean by setting an upper bound, like python_requires='>=3.6,<3.9'?

I think the new problem would be that pip will just loop through releases and reject any with that, but find an older version with python_requires='>=3.6' and fail on that instead.

@eric-wieser
Copy link
Member

Yeah, I think @hugovk's point is a good one here - it sounds like doing this will make things worse not better.

Perhaps we should simply emit a warning in setup.py?

@rgommers
Copy link
Member Author

Good point. Warning in setup.py makes sense to me.

@hugovk hugovk mentioned this issue Oct 4, 2020
Merged
@charris charris mentioned this issue Oct 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgommers rgommers

Labels
component: distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Warn on unsupported Python 3.10+ hugovk/numpy
3 participants
@rgommers @eric-wieser @hugovk