ENH: Warn on unsupported Python 3.10+ #17443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.9 will be released tomorrow and numpy 1.19.3+ will will support it. |
|
Shall I bump it to 3.10+? |
eric-wieser
reviewed
Oct 4, 2020
eric-wieser
reviewed
Oct 4, 2020
Co-authored-by: Eric Wieser <[email protected]>
Yes. 1.19.x already builds with 3.9, we are just waiting for 3.9 to show up on the various platforms for which we produce binary wheels. In general, we try to have a release out within a week or two of the Python release and have working code for the late betas. We can probably update the version when we start testing against it. |
Co-authored-by: Eric Wieser <[email protected]>
eric-wieser
reviewed
Oct 4, 2020
Co-authored-by: Eric Wieser <[email protected]>
eric-wieser
approved these changes
Oct 4, 2020
|
Thanks @hugovk . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17349.
First commit (f3a6b33): warn when installing on unsupported (new) Python versions.
Based on the similar warning we have in Pillow:
(Not sure if this is an ENT or MAINT.)
Second commit (2ebb453): whilst editing
setup.py, I also fixed some Flake8 warnings in there. Let me know if I should drop this commit, or parts of it.