Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH,MAINT: Fix up fortranobject.c and generated C code from F2PY #20053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HaoZeke opened this issue Oct 6, 2021 · 1 comment
Open

ENH,MAINT: Fix up fortranobject.c and generated C code from F2PY #20053

HaoZeke opened this issue Oct 6, 2021 · 1 comment
Labels
component: numpy.f2py

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Oct 6, 2021

Well, fair enough, this is messed up anyway. Although, I don't think it makes sense to ignore these errors. It may make sense to ignore some (python) errors, but these are blanket ignores that may make writing clean python code hard.

Originally posted by @seberg in #20043 (comment)
@HaoZeke HaoZeke changed the title Fix up fortranobject.c ENH,MAINT: Fix up fortranobject.c Oct 19, 2021
@HaoZeke HaoZeke changed the title ENH,MAINT: Fix up fortranobject.c ENH,MAINT: Fix up fortranobject.c and generated C code from F2PY Nov 25, 2023
@HaoZeke
Copy link
Member Author

HaoZeke commented Nov 25, 2023 

          OK, this looks fine.  I will note that `TRYPYARRAYTEMPLATE` looks terrible, assuming this is correct[^1].  It just assumes anything that isn't an array must be `None` (plus a bit of more madness)?

(seems I hadn't actually clicked on start a review...)

Originally posted by @seberg in #24791 (comment)

This was referenced Nov 25, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HaoZeke