Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT: Take a closer look at generated C code from f2py #25200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HaoZeke opened this issue Nov 20, 2023 · 1 comment
Closed

MAINT: Take a closer look at generated C code from f2py #25200

HaoZeke opened this issue Nov 20, 2023 · 1 comment
Labels
component: numpy.f2py

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Nov 20, 2023 

          OK, this looks fine.  I will note that `TRYPYARRAYTEMPLATE` looks terrible, assuming this is correct[^1].  It just assumes anything that isn't an array must be `None` (plus a bit of more madness)?

(seems I hadn't actually clicked on start a review...)

Originally posted by @seberg in #24791 (comment)

Most of the C code isn't tested on the CI either, which is how some other strange bugs (#25186 (comment)) sneak in.
@HaoZeke HaoZeke mentioned this issue Nov 20, 2023
Merged
@HaoZeke
Copy link
Member Author

HaoZeke commented Nov 25, 2023

Closing in favor of updating the older #20053.

@HaoZeke HaoZeke closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: numpy.f2py
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgommers @HaoZeke