Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: einsum with int8/uint8 input is buggy #24732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rgommers opened this issue Sep 17, 2023 · 1 comment
Closed

BUG: einsum with int8/uint8 input is buggy #24732

rgommers opened this issue Sep 17, 2023 · 1 comment
Labels
00 - Bug component: numpy._core
Milestone
2.1.0 release

Comments

@rgommers
Copy link
Member

These tests are failing on macOS x86-64 and with clang-cl on Windows after the move to Meson:

FAILED core/tests/test_einsum.py::TestEinsum::test_einsum_sums_int8 - AssertionError:
FAILED core/tests/test_einsum.py::TestEinsum::test_einsum_sums_uint8 - AssertionError:

It passes with Clang on macOS arm64, and with MSVC on Windows. It's also passing with and without SIMD optimizations. So it's very likely to be a Clang + x86-64 + exact compile flags used bug in the C code somewhere. This needs investigation.
@rgommers rgommers mentioned this issue Sep 17, 2023
Closed
20 tasks
@ViridianMelody ViridianMelody mentioned this issue Feb 6, 2024
Merged
JuliaPoo added a commit to JuliaPoo/numpy that referenced this issue Jun 3, 2024
@JuliaPoo
TST: Re-enable int8/uint8 einsum tests
870936d 
It seems numpy#24732 fixed itself, see the following CI runs:
- github.com/JuliaPoo/numpy/actions/runs/9344912430/job/25716839862
- github.com/JuliaPoo/numpy/actions/runs/9344767573/job/25716459859
@JuliaPoo JuliaPoo mentioned this issue Jun 3, 2024
Merged
@rgommers rgommers added this to the 2.1.0 release milestone Jun 5, 2024
@rgommers
Copy link
Member Author

rgommers commented Jun 5, 2024

This fixed itself somewhere along the way; the tests have been re-enabled in gh-26602.

@rgommers rgommers closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug component: numpy._core
Projects
None yet
Milestone
2.1.0 release
Development

No branches or pull requests
1 participant
@rgommers