Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: array_api.Array has wrong type hints in __getitem__ #24982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Illviljan opened this issue Oct 22, 2023 · 1 comment · Fixed by #25022
Closed

BUG: array_api.Array has wrong type hints in __getitem__ #24982

Illviljan opened this issue Oct 22, 2023 · 1 comment · Fixed by #25022
Labels
00 - Bug 41 - Static typing component: numpy.array_api
Milestone
2.0.0 release

Comments

@Illviljan
Copy link
Contributor

Illviljan commented Oct 22, 2023 •
edited
Loading

Describe the issue:

The __getitem__ is missing a None in the tuple:

numpy/numpy/array_api/_array_object.py

Lines 542 to 548 in 4811db7

def __getitem__(
self: Array,
key: Union[
int, slice, ellipsis, Tuple[Union[int, slice, ellipsis], ...], Array
],
/,
) -> Array:

Probably should look like:
https://github.com/data-apis/array-api/blob/e2b373dd497a1e49b43529e66d1196e504c673cd/src/array_api_stubs/_draft/array_object.py#L502-L506

References:
https://data-apis.org/array-api/latest/API_specification/generated/array_api.array.__getitem__.html
https://data-apis.org/array-api/latest/API_specification/indexing.html

Runtime information:

Seen in main.
@shubhalgupta
Copy link
Contributor

is this issue still open @Illviljan

@Illviljan Illviljan mentioned this issue Oct 28, 2023
Merged
1 task
rgommers pushed a commit that referenced this issue Nov 13, 2023
@Illviljan
TYP: add None to __getitem__ in numpy.array_api (#25022)
3c853e1 
Closes gh-24982
@rgommers rgommers added this to the 2.0.0 release milestone Nov 13, 2023
charris pushed a commit to charris/numpy that referenced this issue Nov 19, 2023
@Illviljan @charris
TYP: add None to __getitem__ in numpy.array_api (numpy#25022)
f32b223 
Closes numpygh-24982
@charris charris mentioned this issue Nov 19, 2023
Merged
1 task
charris pushed a commit to charris/numpy that referenced this issue Nov 19, 2023
@Illviljan @charris
TYP: add None to __getitem__ in numpy.array_api (numpy#25022)
699c7f0 
Closes numpygh-24982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug 41 - Static typing component: numpy.array_api
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging a pull request may close this issue.

TYP: add None to __getitem__ in numpy.array_api Illviljan/numpy
4 participants
@charris @rgommers @Illviljan @shubhalgupta