-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
BUG: build error when numpy
is built with pep517
backend: ERROR: Unhandled python exception
(blas_lapack.py
code needs a small fix)
#25406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The same error on 10.7 x86_64 on buildbot: https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/168185/steps/install-port/logs/stdio |
Update: as @dnicolodi suggested earlier, the cause for the error is in fact
There are two problems here:
|
The code checking for the SDK version need to be read in context: https://github.com/numpy/meson/blob/708d52853d744916884d66a630f20b68cf4d3674/mesonbuild/dependencies/blas_lapack.py#L723-L729 The check is there to ensure that the Accelerate framework is used only on macOS 13.3. Most likely, the fix is to catch the subprocess error and assume the SDK version is too old in this case. |
By the way, the version comparisons here https://github.com/numpy/meson/blob/708d52853d744916884d66a630f20b68cf4d3674/mesonbuild/dependencies/blas_lapack.py#L744C1-L750C65 seem broken to me. What is done is a lexicographic comparison not a version comparison. In other words, if |
@dnicolodi Thank you. That sounds like a good way to solve the problem, then we do not need to bother with finding a way to get SDK version from Python on < 10.8. |
@barracuda156 Please note that the version of macOS you are trying to build for is unsupported at least since November 19, 2015 (end of support for macOS 10.8). There is no realistic way for anyone to test new development on that OS. The amount of things that do not work on that an old system increases exponentially as time passes. If you have hardware that is supported only by such old releases of macOS, installing a different but current OS on it would IMO be time better spent than keep fixing build failures. |
@dnicolodi There is no failures with the build itself, what fails is configure stage, and this is a totally avoidable error. |
numpy
is build with pep517
backend: ERROR: Unhandled python exception
numpy
is built with pep517
backend: ERROR: Unhandled python exception
(blas_lapack.py
code needs a small fix)
Thanks for digging in @barracuda156 and @dnicolodi. I agree with the conversation above - macOS versions that old are unsupported, but in this case the fix is simple enough that we'll fix it. There's no guarantee of there not being more issues on macOS PPC of course. I'm surprised more every year that someone is still using that. |
@rgommers Thank you very much, greatly appreciated! (P. S. As long as GCC upstream supports macOS PPC, it remains usable with much of the modern software running, at least on the late G5 hardware. The Quad with maxed RAM is decently fast in fact.) |
The two things fixed here: - `xcrun` isn't available on very old versions (MacPorts still supports 10.5/10.6) - Version comparison is done correctly now with `mesonlib.version_compare` See numpy/numpy#25406 for the bug report.
This fixes the build for macOS 10.5/10.6, which is still relevant for MacPorts. It also makes version comparisons more robust, so that things won't break if there's ever a 13.10 OS release. Closes numpygh-25406
This fixes the build for macOS 10.5/10.6, which is still relevant for MacPorts. It also makes version comparisons more robust, so that things won't break if there is ever a macOS 13.10 release. Closes numpygh-25406
The fix in gh-25455 should take care of the issues reported here. The plan is to also backport that fix to 1.26.3 |
This fixes the build for macOS 10.5/10.6, which is still relevant for MacPorts. It also makes version comparisons more robust, so that things won't break if there is ever a macOS 13.10 release. Closes numpygh-25406
The two things fixed here: - `xcrun` isn't available on very old versions (MacPorts still supports 10.5/10.6) - Version comparison is done correctly now with `mesonlib.version_compare` See numpy/numpy#25406 for the bug report.
Uh oh!
There was an error while loading. Please reload this page.
Describe the issue:
When trying to build
numpy
, I get the following error during evaluating BLAS variants:The issue appears specific to
pep517
backend: on the same system, it does not happen ifpep517
is disabled.See also:
mesonbuild/meson-python#554
https://trac.macports.org/ticket/68908#comment:10
@rgommers Confirmed the same failure on 10.6.8
x86_64
(so error is unrelated to PowerPC or Rosetta).Reproduce the code example:
This is a build (or rather configure) error. What seems to fail is this chunk:
Error message:
10.6.8 Rosetta:
10.6.8 Intel:
Python and NumPy Versions:
numpy
1.26.1python
3.11.4Runtime Environment:
macOS 10.6.8
x86_64
macOS 10.6.8
ppc
(Rosetta)Context for the issue:
numpy
is broken in Macports for a number of systems after it switched to pep517 backend. Given that Python 3.12+ needs that, reverting is not an option.The text was updated successfully, but these errors were encountered: