-
-
Notifications
You must be signed in to change notification settings - Fork 11k
ENH: Automatic copy on overlap #6272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's done for (g)ufuncs (and thus also for in-place binops and most of numpy.linalg), and dot. There however may still be some problematic code paths in other operations, such as in indexed assignment. I did not make an exhaustive check on what's left. |
It is true, it might be only smaller things left, had not thought about it much (in general things with an out argument are in danger that are not a ufunc):
|
Reviewing this as part of my 10 random issues, as requested in a 3/20/19 request. I am 95% sure this is done and just forgotten to be closed, because in 2019 I have seen these overlap checks in the assignment code, including in code involving assignment to slices of an array. I'm going to go ahead and close this, please reopen if that's wrong. |
Is this really safe to close? Has anyone checked the list above? |
But specifically - has someone gone through that list above and checked whether they are resolved or not? It seems to me that this issue should stay open until someone has done that. |
I'll go through it now... |
Indexing assignments do use it, advanced indexing does not. I doubt a lot of the other functions I listed above |
These seem OK:
Problematic:
Note that for both of these, with So if we think those last ones should be fixed, we should keep this open. |
Closing, #13182 covered the last outstanding cases. Please reopen if I misunderstood |
Uh oh!
There was an error while loading. Please reload this page.
Tracking issue as a continuation to gh-6166
dot()
BUG: core: in dot(), make copies if out has memory overlap with input #8539Some initial code, master...pv:copy-overlap
The text was updated successfully, but these errors were encountered: