-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Document, deprecate or simply remove np.datetime_as_string #7025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The usual rule is to deprecate before removing, and actual usage is more In the process of making datetime64 time zone naive (#6453 The function provides the ability to print datetimes assumed to be numpy/numpy/core/tests/test_datetime.py Line 1317 in c45f3e7
for examples. As such, it doesn't really fit in with the new time zone naive datetime64. Removing it would let us delete a significant block of code. I could simply deprecate the timezone handling, but without timezone cc @PythonCHB https://github.com/PythonCHB — |
@shoyer is there a serious gain of removing it (except removing dead code)? Do you need it removed to move forward with other things, or did the function break in some cases? |
The function still works properly, under the assumption that all naive datetimes are UTC. So I agree we can simply deprecate it without any harm. That's probably the safest path forward. On Sat, Jan 16, 2016 at 1:34 AM, seberg [email protected] wrote:
|
On Saturday, January 16, 2016, Stephan Hoyer [email protected]
Or the assumption that the datetime you call this function with is UTC. So I'd say the deprecation warning and see if anyone squawks .... -CHB Christopher Barker, PhD Python Language Consulting
|
In the process of making datetime64 time zone naive (#6453), I came across this function that was added as part of datetime support, but that unfortunately @mwiebe never got around to documenting. Nonetheless, it can of course be found in the wild -- my github search also found a few snippets, though AFAICT it's not used in any major projects.
The function provides the ability to print datetimes assumed to be specified in UTC with different precision and time zones. See its unit tests for examples. As such, it doesn't really fit in with the new time zone naive datetime64. Removing it would let us delete a significant block of code.
I could simply deprecate the timezone handling, but without timezone handling it doesn't do very much. So I'm inclined to remove the entire rarely used function. Given that it's not documented, do we need it to go through a normal deprecation cycle?
cc @PythonCHB
The text was updated successfully, but these errors were encountered: