fixed asscalar error on floats #10659
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #4701, I think |
mhvk
reviewed
Feb 25, 2018
There was a problem hiding this comment.
See #5126 (comment) where it was suggested to just leave things as is. If we do that, we should at least close the issue! Though I think we might as well just apply this fix, and add the test (see in-line comments).
numpy/lib/tests/test_type_check.py
Outdated
| class TestAsScalar(object): | ||
|
|
||
| def test_basic(self): | ||
| a = asscalar(np.array([1])) |
numpy/lib/tests/test_type_check.py
Outdated
| def test_basic(self): | ||
| a = asscalar(np.array([1])) | ||
| assert_equal(a.__class__, int) | ||
| assert_raises(ValueError, asscalar,[1,2]) |
There was a problem hiding this comment.
Please add spaces after , (pep8)
added 2 commits
February 25, 2018 14:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed error encountered on passing floats to asscalar().
done at HackIllinois 2018