MAINT/DEP: properly implement ndarray.__pos__
#11450
Conversation
numpy/core/src/multiarray/number.c
Outdated
| PyObject *mod; | ||
| if (mod) { | ||
| Py_DECREF(mod); | ||
| } |
There was a problem hiding this comment.
Oops, leftover from debugging!! (I had the problem that has_not_default... doesn't work when an error is set)
|
Why was this different, historically, than |
325e0b6 to
31ac6cd
Compare
|
@mattip - I'm guessing it was just a short-cut. Certainly, |
| @@ -61,7 +61,7 @@ get_non_default_array_ufunc(PyObject *obj) | |||
| * Returns 1 if this is the case, 0 if not. | |||
| */ | |||
|
|
|||
| static int | |||
| NPY_NO_EXPORT int | |||
There was a problem hiding this comment.
nit: This doesn't belong in this PR
|
Commit tag should definitely contain |
b770252 to
f13ab50
Compare
|
OK, I changed the commit message to include "DEP". |
numpy/core/src/multiarray/number.c
Outdated
| } | ||
| /* 2018-06-28, 1.16.0 */ | ||
| if (DEPRECATE("Applying '+' to a non-numerical array is " | ||
| "ambigous. Returning a copy, but in the future " |
There was a problem hiding this comment.
Typo: ambiguous.
Is this even true? It's just ill-defined (no possible meanings), not ambiguous (>1 possible meanings).
There was a problem hiding this comment.
OK, replaced with "ill-defined".
f13ab50 to
ac1e129
Compare
|
@eric-wieser - I addressed your comment. OK to merge? |
|
@eric-wieser could you comment on the changes you requested? @mhvk it seems a rebase is needed |
Rather than rely on +array doing that for it.
For regular arrays, we now give a deprecation warning if np.positive cannot handle it; for ndarray subclasses that override __array_ufunc__, we pass on the type error.
ac1e129 to
3207785
Compare
|
@mattip - thanks for noticing... now rebased and approved, so can go in if tests pass. |
ndarray.__pos__
fixed #9081
For regular arrays, we now give a deprecation warning if np.positive cannot handle it; for ndarray subclasses that override array_ufunc, we pass on the type error.