MAINT: Move add_newdocs into core, since it only adds docs to those pieces #11474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b95c95 to
2244cd9
Compare
|
I've not got python 3.7 installed, but would be curious to see what the import time graph looks like with this PR. |
|
Agree, I've been tempted to do the same, I've looked for it in core more than once ... |
|
Seems like a good idea too. |
|
Looks like all the |
|
|
Thanks Eric. |
This was referenced Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon gh-11473. Once that one is merged, toggle the base branch of this PR to see the updated diff
This results in a more reasonable import sequence.