-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
DOC: add docstrings for numeric types #11858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charris
merged 22 commits into
numpy:master
from
YannickJadoul:np.core.numerictypes-doc
Sep 18, 2018
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1c39fe2
DOC: add docstrings for uint8, uint16, uint32, uint64 (see #10106)
YannickJadoul ee6019c
DOC: make numeric types' docstrings char codes formatting consistent
YannickJadoul 962944a
DOC: add docstring for np.float16 (see #10106)
YannickJadoul 9030871
DOC: Adding documentation to C/Python compatible names of scalar types
YannickJadoul e6b951b
DOC: Adding platform-dependent aliases to scalar type docstrings
YannickJadoul 03a5d22
DOC: Fix typos and minor issues in scalar type docstrings
YannickJadoul 039fbe1
DOC: Add hard-coded aliases to scalar type docstrings
YannickJadoul 05651e1
DOC: Fix platform-dependent aliases in doc string of scalar types
YannickJadoul 3577f48
DOC: Fix indentation of numeric types' docstring
YannickJadoul 4980f4b
TST: Add test checking for platform-dependent generation of numeric t…
YannickJadoul 491343b
TST: Fix docstring test failures when PYTHONOPTIMIZE/Py_OptimizeFlag > 1
YannickJadoul 9cd199b
TST: Moving check of PYTHONOPTIMIZE for test_numerictypes.py::TestDoc…
YannickJadoul 2c80d46
DOC: Cleanup code for adding docstrings to numeric types and mention …
YannickJadoul 59191e1
DOC: Cleaning up access of numeric type objects and character codes i…
YannickJadoul 5df8a13
DOC: Prepend 'np.' to numeric type docstrings
YannickJadoul 9731928
MAINT: Remove dead code, rename function
eric-wieser 71a383c
DOC: Cleaning up numeric_type_aliases in core/_add_newdocs.py
YannickJadoul 722c30e
DOC: Fixing dynamic aliases in docstrings for complex scalar types
YannickJadoul f073811
DOC: Removing docstrings for complex scalar types in numpy/core/src/m…
YannickJadoul 857cd9a
DOC: Merging lists of different dynamic aliases into one, and prepend…
YannickJadoul dff5de6
DOC: Adding scalar type docstring improvements to release notes
YannickJadoul 1561b9c
DOC: Tweak release notes
eric-wieser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any real value to having these four separate lists of aliases, rather than building one big list to perform the lookup in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Euhm, yeah, the idea was not not loop over irrelevant aliases (while. But that does seem to come at the cost of being slightly more error-prone. I'm guessing you prefer the side of the trade-off that's less error-prone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, especially since collectivey we've proven that that type of error is easy to make and hard to spot. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One less argument to
add_newdoc_for_scalar_type
as well, as bonus.