Provide information about what kind is actually not integer kind #12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it is hard to impossible to figure out what is the actual value which fails the test. See e.g. failing on 3.4 (only) tests of nibabel: https://ci.appveyor.com/project/nipy/nibabel/build/1.0.498/job/eechfm1kxroa0rju#L598
tylerjereddy
reviewed
Oct 5, 2018
| @@ -513,7 +513,7 @@ def __init__(self, int_type): | |||
| self.bits = self.dtype.itemsize * 8 | |||
| self.key = "%s%d" % (self.kind, self.bits) | |||
| if self.kind not in 'iu': | |||
| raise ValueError("Invalid integer data type.") | |||
| raise ValueError("Invalid integer data type %r." % (self.kind,)) | |||
There was a problem hiding this comment.
Looks harmless at first glance if it helps a downstream project. I don't think we have plans to explicitly support Python 3.4 issues moving forward, but this may be fair enough.
I suppose one could add a unit test that uses a regex on the ValueError message, although maybe that's overkill.
There was a problem hiding this comment.
FWIW those failures also happen with 3.5 at times (so I was told), or I misunderstood and this code path is 3.4 specific?
There was a problem hiding this comment.
If the issue isn't 3.4-specific that probably make a more compelling case to fix it
|
The code is already tested in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it is hard to impossible to figure out what is the actual
value which fails the test.
See e.g. failing on 3.4 (only) tests of nibabel:
https://ci.appveyor.com/project/nipy/nibabel/build/1.0.498/job/eechfm1kxroa0rju#L598