MAINT: Update cversion hash. #12414
Merged
MAINT: Update cversion hash. #12414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Nov 19, 2018
| # Version 13 (NumPy 1.16) | ||
| # Deprecate PyArray_SetNumericOps and PyArray_GetNumericOps, | ||
| # Add fields core_dim_flags and core_dim_sizes to PyUFuncObject. | ||
| # Add pyufunc_fromfuncanddataandsignatureandidentity to ufunc_funcs_api. |
There was a problem hiding this comment.
Should this not have the same case as the function name?
eric-wieser
reviewed
Nov 19, 2018
| @@ -402,8 +402,7 @@ | |||
| # End 1.7 API | |||
| 'PyUFunc_RegisterLoopForDescr': (41,), | |||
| # End 1.8 API | |||
| 'PyUFunc_FromFuncAndDataAndSignatureAndIdentity': | |||
| (42,), | |||
| 'PyUFunc_FromFuncAndDataAndSignatureAndIdentity': (42,), | |||
There was a problem hiding this comment.
Note that I wrapped this to make the columns align - not that it matter at all
|
Perhaps that warning should be promoted to an error at build time, else we'll never catch it. |
A new function was added to the ufunc_funcs_api. Closes numpy#12412.
fa2c948 to
0f65a90
Compare
|
Hah, that was strange. I upgraded to Fedora 29 last Thurs, and among various new vim bugs, it turns out it was lower casing strings copied to the clipboard. Seems vim is not maintained as well as it was... |
Sounds like a good idea. |
eric-wieser
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new function was added to the ufunc_funcs_api.
Closes #12412.