TST: Azure Python version fix #12502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Azure test results are now published with appropriate Python version strings
|
Where is that information located? I cannot find it. |
|
Yeah, it is a pain to find it -- https://dev.azure.com/numpy/numpy/_build/results?buildId=1155&view=ms.vss-test-web.test-result-details Then there's an "x" to click on the right side to clear filters, and then you can click show more results (I didn't design it!). |
eric-wieser
approved these changes
Dec 9, 2018
|
Thanks Tyler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12298 by using proper string variable substitutions or just hard-coding for "single-matrix" runs (mac, linux have a single job). Also, reduce ambiguity with respect to architecture and fast / full test runs.
The Azure
PublishTestResultstask was not able to substitute Python version strings so we're seeing reports like this for merge event CI runs:For pull request CI runs it currently looks more like this:
The 6 missing publication entries for PR runs are all for Windows, and @charris has already noted the Warnings on the test publication task for Windows. In fact, there are 12 such warnings on PRs (2 per windows job), and 6 such warnings for merge events (1 per Windows job).
My objective here is to deal with the simple linked issue first -- get those version strings working sensibly, and then look at the deeper issues on
PublishTestResultsWindows warnings after that.On my branch, the changes in this PR produce this:
And hopefully works similar for master branch PR here.