TST: add MSVC 2015 / Python 3.5 to CI #12529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have got failures, but they look unrelated to Eric's problem. |
|
Comparing the azure logs against my local logs when compiling Perhaps the absense of CBLAS is causing trouble, but that seems awfully unlikely. --- yours
+++ mine
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\x86_amd64\cl.exe
/c
/nologo
/Ox
/W3
/GL
/DNDEBUG
/MD
-DNPY_INTERNAL_BUILD=1
-DHAVE_NPY_CONFIG_H=1
-D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE=1
- -D_LARGEFILE64_SOURCE=1
- -DHAVE_CBLAS
+ -D_LARGEFILE64_SOURCE=1
-Ibuild\src.win-amd64-3.5\numpy\core\src\umath
-Ibuild\src.win-amd64-3.5\numpy\core\src\npymath
-Ibuild\src.win-amd64-3.5\numpy\core\src\common
-Inumpy\core\include
-Ibuild\src.win-amd64-3.5\numpy\core\include/numpy
-Inumpy\core\src\common
-Inumpy\core\src
-Inumpy\core
-Inumpy\core\src\npymath
-Inumpy\core\src\multiarray
-Inumpy\core\src\umath
-Inumpy\core\src\npysort
- -IC:\Python35\include
- -IC:\Python35\include
+ -IC:\Program Files\Python 3.5\include
+ -IC:\Program Files\Python 3.5\include
-Ibuild\src.win-amd64-3.5\numpy\core\src\common
-Ibuild\src.win-amd64-3.5\numpy\core\src\npymath
-Ibuild\src.win-amd64-3.5\numpy\core\src\common
-Ibuild\src.win-amd64-3.5\numpy\core\src\npymath
-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE
-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\ucrt
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\ucrt
-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\shared
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\um
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\winrt
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\shared
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\um
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\winrt
-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE
-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\ucrt
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\ucrt
-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\shared
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\um
- -IC:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\winrt
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\shared
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\um
+ -IC:\Program Files (x86)\Windows Kits\10\include\10.0.16299.0\winrt
/Tcbuild\src.win-amd64-3.5\numpy\core\src\umath\loops.c
/Fobuild\temp.win-amd64-3.5\Release\build\src.win-amd64-3.5\numpy\core\src\umath\loops.obj |
|
Adding the compiler tag and closing this -- if we're not going to detect regression on issues for older compilers there's not much point in having an older compiler test build occupy a CI slot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on comment suggesting we do this to reproduce the test failures reported in #12520.
Of course, what this currently does is fail other tests for reasons I don't fully understand, instead of reproducing the desired failures.
If past experience is any guide, getting the CI run to work just right for this older compiler set without pre-installed Python 3.5 on the image could be more challenging than fixing the bug itself, but may be worth it to prevent regressions, etc.
Some paths / library paths may still need adjusting given the "manual" install of Python vs. the pre-loaded cases in our newer-compiler matrix for Windows.