Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP, TST: fix 1 Azure Windows warning #12531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tylerjereddy
Copy link
Contributor

@charris noted Azure Windows warnings. In PR CI runs there are two types of such Warnings on Azure Windows jobs: 1 warning related to complete blocking of the publication of the test results, and the other about lacking build info.

This PR should fix 1 of those warning categories, and a reviewer should be able to navigate to the Azure page and confirm that this PR was 1 warning per Windows publish event vs. 2 warnings per Windows publish event on other recent PRs. The remaining warning is related to build data as discussed in #12530, and I'll likely handle that separately.

A reviewer should also be able to confirm that the test tab on Azure summary page for PR CI runs include > 50,000 tests vs. only about 14,000 tests (Linux + Mac only) on recent PR CI runs. Runs after merging to master were less problematic--they are only missing the build info for Windows, so 1 warning only there already.

The idea behind the fix is simply to be more explicit about the path used for generating & searching for junit xml test files on Windows jobs. Paths just work out better for Posix images, for now anyway, so no special treatment needed for them.

* use a more explicit path when
generating and searching for junit
xml files in Azure Windows CI to
restore publication of test results
in PR branch CI runs
@tylerjereddy tylerjereddy changed the title TST: fix 1 Azure Windows warning WIP, TST: fix 1 Azure Windows warning Dec 11, 2018
@tylerjereddy
Copy link
Contributor Author

Adding WIP tag -- apparently the reduced warnings on my fork runs were related to being on the fork and manually triggered, so perhaps more like the merge events. Confusing!

@tylerjereddy
Copy link
Contributor Author

Here's the fork result with less warnings on the same commit hash: https://dev.azure.com/tylerjereddy/numpy-test/_build/results?buildId=512&view=logs

@mattip
Copy link
Member

mattip commented Dec 12, 2018

It is strange that this is needed, and not mentioned in the Azure docs. Have you talked to the Microsoft folks who commented elsewhere: @ericsciple @chrisrpatterson?

@tylerjereddy
Copy link
Contributor Author

Yeah, some feedback from Microsoft would be much appreciated.

@tylerjereddy
Copy link
Contributor Author

The Azure Windows job warnings have dropped from 2 per job to 1 per job on PRs all of a sudden -- we can see 2 in this PR CI, and 1 per Windows job in more recent PRs.

I suspect this is stuff getting fixed on Microsoft's end & we can perhaps safely ignore for the time being.

@tylerjereddy tylerjereddy added the 57 - Close? Issues which may be closable unless discussion continued label Dec 13, 2018
@chrispat
Copy link

Hello all, sorry for the delay in response.

At the surface, those warnings look more like a temporary service issue of some sort. I will have someone look into it and see what we can figure out.

@chrispat
Copy link

From what we can see there was a feature flag that was set incorrectly earlier this week. That should be fixed in all places now. Please let me know if you continue to see all of those errors.

@tylerjereddy
Copy link
Contributor Author

I think ##[warning]Could not publish build level data. Object reference not set to an instance of an object. persists for both SciPy & NumPy libraries, on Windows builds.

@charris
Copy link
Member

charris commented Dec 21, 2018

Seems to have gotten fixed: https://github.com/numpy/numpy/pull/12596/checks

@charris
Copy link
Member

charris commented Dec 31, 2018

Can we close this? Azure is no longer reporting warnings.

@tylerjereddy
Copy link
Contributor Author

Yes, this whole thing was on Microsoft's end & not related to anything we'd been doing incorrectly.

@tylerjereddy tylerjereddy deleted the azure_win_warns branch December 31, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 - Testing 25 - WIP 57 - Close? Issues which may be closable unless discussion continued
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants