BUG: disable flaky sanity checks #12637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another "fix" would be to revert PR #12618 |
|
@ahaldane Comment? |
|
@mattip Please label your PRs. |
|
I'm going to wait a bit longer before acting on this. What happens if you simply remove the |
|
Let my try to fix in the next few hours. If I'm not done go ahead and merge this for now so we can fix later. |
|
Closing in favor of #12626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 12 to the stress test for alignment is exposing bugs in the
assertthat the alignment is correct. PR #12626 is intended to fix the additional cases exposed in the stress test, but seems to have a problem:assertswheresizeof(npy_longdouble) == 16and its alignment is 8assertswheresizeof(npy_longdouble) == 12(32 bit linux) and its alignment is 4.Note that the actual decision aligned/not aligned has not changed, only the
asserts to check that everything is OK. Thoseasserts only fire when compiling with-UNDEBUGto undefineNDEBUGand allow theassertstatements to work.I propose we temporarily disable the asserts to allow work to continue, until #12626 can be merged.