ENH,WIP: alternative method to implement a where argument to ufunc reductions #12640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iterator masking is unsuited, as it prevents writing back an element to an array, while what is needed is to skip even reading/operating on an element. Might need a double internal loop, where the operand is filled in with an identity whenever the mask is set.
Since this changes behaviour for cases where it may not be necessary, this should really involve a new flag!
This was referenced Jan 1, 2019
|
closing in favour of the simpler and faster solution in #12644, which doesn't require messing with the iterator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seberg - here's an attempt where I force the iterator to feed an axis being reduced to the inner loop. Right now, it just does it, which causes a test failure that expects something else.
An advantage of this approach is that it is now more reasonable to ask people to provide
initialfor reductions that do not have an identity - it will now not be used to fill in masked items.But it needs a better way to force the iterator to