Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT: Removed unused and confusingly indirect imports from mingw32ccompiler #12894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 31, 2019

Both of these functions are better exposed through distutils.ccompiler, but neither are used anyway

@eric-wieser
Copy link
Member Author

It worries me that parts of numpy.distutils don't even have basic importability coverage.

…ompiler

Both of these functions are better exposed through `distutils.ccompiler`, but neither are used anyway
@eric-wieser
Copy link
Member Author

Scratch that - there's a from distutils.ccompiler import * hiding in numpy.distutils.ccompiler, so there's no error here. Changing to a MAINT.

@eric-wieser eric-wieser force-pushed the distutils-broken-import branch from 6330647 to 35cc57f Compare January 31, 2019 06:59
@eric-wieser eric-wieser changed the title BUG: Fix ImportError for mingw32ccompiler MAINT: Removed unused and confusingly indirect imports from mingw32ccompiler Jan 31, 2019
@eric-wieser eric-wieser removed this from the 1.16.1 release milestone Jan 31, 2019
@charris
Copy link
Member

charris commented Feb 3, 2019

close/reopen

@charris charris closed this Feb 3, 2019
@charris charris reopened this Feb 3, 2019
@mhvk
Copy link
Contributor

mhvk commented Feb 4, 2019

Don't know how removing a line of code can lead to reduced coverage, but otherwise the tests passed, so merging.

@mhvk mhvk merged commit c009e1b into numpy:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants