MAINT: Replace if statement with a dictionary lookup for ease of extensibility in ufunc generator #13031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsibility in ufunc generator
eric-wieser
commented
Feb 25, 2019
| F='nc_%sf', | ||
| D='nc_%s', | ||
| G='nc_%sl' | ||
| ) |
There was a problem hiding this comment.
This isn't really relevent, but I think it is a little clearer
|
Thanks Eric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another blocker for #12519 .
Also removes some instance of by-column wrapping, which is enough to trick my editor into thinking this file uses 2-space indents.