BLD: streamlined library names in site.cfg sections #13157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
651a845 to
48a017e
Compare
eric-wieser
reviewed
Mar 19, 2019
eric-wieser
reviewed
Mar 19, 2019
eric-wieser
reviewed
Mar 20, 2019
46dfaf9 to
d022eb2
Compare
This unifies the names for retrieving libraries in sections. Previously one could only get umfpack libraries using: [umfpack] umfpack_libs = ... while now it prefers to use [umfpack] libraries = ... (but defaults to use umfpack_libs). Some libraries is system_info uses libraries whereas others were using *_libs as keys. All future developments I think should retain the libraries keyword, and only if applicable for sub-packages it should be deferred to more _libs entries. Signed-off-by: Nick Papior <[email protected]>
d022eb2 to
22da0b9
Compare
eric-wieser
reviewed
Mar 23, 2019
eric-wieser
reviewed
Mar 26, 2019
This enables one to force users to use only one keyword in the site.cfg file for distutils. Signed-off-by: Nick Papior <[email protected]>
|
@eric-wieser, @rgommers I have marked conversations as resolved. Please reopen if needed! |
mattip
reviewed
Mar 27, 2019
mattip
reviewed
Mar 27, 2019
|
Could use some new tests in |
Added! |
aac9fa5 to
f29e4bf
Compare
Signed-off-by: Nick Papior <[email protected]>
f29e4bf to
6993157
Compare
Signed-off-by: Nick Papior <[email protected]>
|
@mattip fixed remaining issues! |
This unifies the names for retrieving libraries in sections. Previously one could only get umfpack libraries using: [umfpack] umfpack_libs = ... while now it prefers to use [umfpack] libraries = ... (but defaults to use umfpack_libs). Some libraries is system_info uses libraries whereas others were using *_libs as keys. All future developments I think should retain the libraries keyword, and only if applicable for sub-packages it should be deferred to more _libs entries. Signed-off-by: Nick Papior <[email protected]>
This enables one to force users to use only one keyword in the site.cfg file for distutils. Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
|
It would be nice to document this but ...
Could you take a look at both those files anyway ( |
Signed-off-by: Nick Papior <[email protected]>
mattip
reviewed
Apr 29, 2019
Signed-off-by: Nick Papior <[email protected]>
|
LGTM. Will give other reviewers a chance to take a look before merging |
|
Thanks @zerothi |
lijunzh
added a commit
to lijunzh/numpy
that referenced
this pull request
May 2, 2019
* master: (25 commits) BUG: fix unravel_index when dimension is greater than 'intp' MANT: refactor unravel_index for code repetition (numpy#13446) BLD, TST: implicit func errors DOC: document existance of linalg backends BLD: streamlined library names in site.cfg sections (numpy#13157) MAINT: fixed typo 'wtihout' from numpy/core/shape_base.py BUG: fixing bugs in AVX exp/log while handling special value floats (numpy#13415) update sequence Add analysis check BUG: blindly add TypeError to accepted exceptions MAINT: fixed several PYTHONOPTIMIZE=2 failures BUG: fixed PYTHONOPTIMIZE run MAINT: fixed typo 'Mismacth' from numpy.core.setup_common.py MAINT: fixed last issues and questions according to numpy#13132 MAINT: improve efficiency of pad by avoiding use of apply_along_axis DOC: dimension sizes are non-negative, not positive BUILD, BUG: fix from review, fix bug in git_version MAINT: mention 'make dist' in error messsage BUILD: allow version-check to pass if GITVER is Unknown (sdist build) BUILD: fail documentation build if numpy version does not match ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the names for retrieving libraries in sections.
Previously one could only get umfpack libraries using:
while now it prefers to use
(but defaults to use umfpack_libs).
Some libraries is system_info uses libraries whereas others were using
*_libsas keys. All future developments I think should retain thelibraries keyword, and only if applicable for sub-packages it should
be deferred to more
_libsentries.This commit also fixes CBLAS linkage if the user has supplied a
sufficient library. I.e. it first checks whether the CBLAS interface
is present as is, then tries to add cblas, etc.
It should at least now work for more diverse libraries.