-
-
Notifications
You must be signed in to change notification settings - Fork 11k
BLD: Add libflame as a LAPACK back-end #13158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will need a release note at some point. |
@charris could you guide me towards this? Where should I add stuff? (note I already added flame to the documentation). |
If you could add a note on both this PR and gh-13132 to |
@rgommers could you see if 3b5b21c is fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @zerothi. I just suggested a few small tweaks.
Now libflame may be used as a LAPACK back-end. libflame requires an external BLAS so one has to also have this enabled. Also added release notes for NPY_*_ORDER and libFLAME.
@rgommers I can't see why the Windows Python36 fails, but Windows Python37 does not... It seems I don't have permission to re-run the test? |
Hmm, that looks unrelated but since it's in linalg I'd like to rerun the tests. Unfortunately I can't trigger a rerun either. @tylerjereddy could you trigger the rerun on Azure, and perhaps also add me ( |
I've triggered the re-run. |
Failure is still there for 32-bit Python 3.6 Windows, so maybe real. Various ways to debug--normally I'd set up Azure on a fork and play with the CI until I identify the specific test that crashes--maybe using a more verbose output. @rgommers ok, you're an admin for NumPy Azure account now. Stephan Hoyer, Matti, and Chuck should also be admins. |
@tylerjereddy @rgommers I am still very puzzled by the apparent show of linalg error in one build. Is there anything I can do? |
Hmm the build logs for the failures have disappeared. I've triggered a re-run |
Signed-off-by: Nick Papior <[email protected]>
All green, in it goes. Thanks @zerothi! |
This adds libflame to the available list of LAPACK implementations.
It requires #13132 before merging (which is why this is a draft for now!)