WIP, BUG: exp, log AVX loops do not use steps #13517
Conversation
|
Still need to work |
|
@r-devulap you can issue a PR to this branch or start a new branch with some form of this test To issue a PR against this branch (assuming I have no bugs in this code): then go to |
|
@mattip thanks. I am working on a fix and will submit them to this PR. |
|
|
||
| @pytest.mark.parametrize('ufunc', [getattr(np, x) for x in dir(np) | ||
| if isinstance(getattr(np, x), np.ufunc)]) | ||
| def test_ufunc_noncontiguous(ufunc): |
There was a problem hiding this comment.
a ufunc test for overlapping input and output memory is needed for vectorization too
_gen_alignment_data produces a bunch of data for unary and binary simd tests (though not strided)
but it creates a huge amount of test cases which makes tests slow
nowadays atleast on x86 you don't need the alignment stuff anymore so maybe overlapping input and output for unary and binary functions is enough?
There was a problem hiding this comment.
Would it be enough to set func(*args, out=arg[0]) or would you like to see offset overlap as well?
|
Duplicate of #13520, closing |
Fixes #13512 by considering steps in the inner loop
Still a WIP - added a test for all ufuncs