BUG: Workaround for bug in clang7.0 #13623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue 13586
|
I am just avoiding use of _CMP_LE_OQ for NAN's by replacing NAN's with zero's early. That should prevent the exception. @tylerjereddy could you please try this and let me know if it fixes the failing test? |
tylerjereddy
approved these changes
May 28, 2019
There was a problem hiding this comment.
I confirmed that the full test suite passes using this feature branch, while the single failing test persists on the latest master branch on my mac laptop.
So, +1 to merge.
I'll let another maintainer do that though--I'm still catching up on NumPy repo notifications so I'm not sure on release cycle sensitivity to merges at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #13586