MAINT: Revert #13876, "MAINT,BUG,DOC: Fix errors in _add_newdocs" #13943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ac7fa9.
|
ISTR having that problem with a squash commit :) |
|
Although I'm not convinced it is worth the hassle just to clean that up. |
|
Hassle is minimal if I merge my own no-op PRs ;) |
|
@eric-wieser sorry for the mess |
|
@mattip: No worries, it's easy to fix |
|
@charris: good guess, this was not worth it, and actually made things worse... Before:
After:
Going to contact github and ask if this is intended behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13876.
Doing this so that I can reapply it without a squash commit, which will result in the github page at b592e8f showing
masteras one of the branches this fix is present in.This only works if done as two separate PRs.