MAINT: Improve import time: Avoid importing secrets #14094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think 1ms is worth it. Are the two options the same? Note that we will be dropping Python 3.5 when 3.8 comes out. |
|
yeah, probably not, especially since I like that we are explicit about wanting a "secure" random number generator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is admittedly a really small gain.
I think it only avoid the import of hashlib.
Feel free to just shut this one down if it isn't worth your keystrokes.
I think the gain here is on the order of 1ms. Hard to measure.
It avoid the import of
hashlibandhmac