TST, MAINT: include numpy package in .coveragerc #14347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* based on coveragepy docs and .coveragerc files in Python projects with more comprehensive codecov reports available (like scikit-learn), adjust .coveragerc to use the source directive to explicitly include the numpy package / namespace instead of using the include file selection directive
Contributor
Author
|
oy, codecov -- not sure what to make of that, but it doesn't let me click through
|
eric-wieser
reviewed
Aug 24, 2019
* try setting the coverage "source" directive to the numpy repo root, based on reviewer feedback in PR 14347
Member
|
No change from this PR it seems, coverage is incomplete:
|
Member
|
@tylerjereddy any ideas? |
Member
|
Something happended to codecoverage reporting. If I go back to an older PR I can drill down into the files but at some stage that stopped working. |
Contributor
Author
|
Yeah, it is strange. It stopped working for SciPy for other reasons & they weren't responsive to a polite inquiry either. |
Member
|
@tylerjereddy Should we close this? |
Contributor
Author
|
Sure, I'll close it--we have a contact on codecov team if there are residual issues with how it is behaving for NumPy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.coveragercfiles inPython projects with more comprehensive codecov reports
available (like scikit-learn), adjust
.coveragerctouse the
sourcedirective to explicitly include thenumpy package / namespace instead of using the
includefile selection directiveEric noticed this in #14310 (comment)
Clicking through our codecov badge it looks like pretty much all
numpy.submodulenamespaces are now completely ignored by codecov--the only files and folders I see showing up seem to be those that get fused in fromgcovreport files on compiled files! This simple fix is worth a try... seems to work forscikit-learn& seems to be more appropriate directive based on docs