Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: clarify residual in np.polyfit #14629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Conversation

sethtroisi
Copy link
Contributor

Closes #7213

wording matches resid -- sum of squared residuals of the least squares fit which is present in several files (polynomial.py, _polybase.py, hermite.py, ...)

Present only if `full` = True. Residuals is sum of squared residuals
of the least-squares fit, the effective rank of the scaled Vandermonde
coefficient matrix, its singular values, and the specified value of
`rcond`. For more details, see `linalg.lstsq`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip - these attempted links to parameters should raise sphinx warnings, and ideally the docs build test should fail on those?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for sphinx to catch these, we need to run with -n, which currently spits out over 1000 warnings. xref gh-14699 which fixes the common and non-controversial ones, and issue gh-14699 for tracking progress

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, indeed. I assumed without much thinking that this was turned on already, sorry for the noise then.
If an extra pair of hand would help, let me know, messing with sphinx is well within my comfort zone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a review of #14699 would be helpful, and continuation of the work would be great

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't raise warnings, usage is correct here. At least, this is what the numpydoc spec says. And the rendering can be controlled, see numpy/numpydoc#233

@rgommers rgommers merged commit 49deaff into numpy:master Oct 18, 2019
@rgommers
Copy link
Member

Merged, thanks @sethtroisi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polyfit reference: definition of 'residuals'
4 participants