MAINT: cleanup compat.py3k.py #15011
Conversation
|
Probably worth updating the docstring at the top to indicate that:
|
aab4517 to
fda43db
Compare
That would be my main concern. I haven't checked this PR, but none of the functions currently available for Python3 should disappear. We are also waiting for 1.19 development to start before doing Python2.7 cleanups, there are other pending PRs making a start on that. Note that internal cleanups are less problematical than changes to the public API. |
This PR has been restricted to strictly internal cleanups, and the should not affect the public facing API at all. That said, it does fall in the realm of 2.7 cleanups, which are good to wait on. |
numpy/compat/py3k.py
Outdated
| """ | ||
| Python 3 compatibility tools. | ||
| Python 3.X compatibility tools. | ||
|
|
||
| """ | ||
| from __future__ import division, absolute_import, print_function | ||
| While this file was originally intented for Python 2 -> 3 transition, | ||
| it is now used to create a compatibility layer between different | ||
| minor versions of Python 3. | ||
|
|
||
| While the active version of numpy may not support a given version of python, we | ||
| allow downstream libraries to continue to use these shims for forward | ||
| compatibility with numpy while they transition their code to newer versions of | ||
| Python. | ||
| """ |
There was a problem hiding this comment.
Great comment, thanks - to the extent that I'd consider merging a PR with only this change in for 1.18.0, if it's worth your time to rebase.
269cdf2 to
9285702
Compare
|
@hmaarrfk It is finally time for 2.7 cleanups! Would you mind rebasing on master? |
9285702 to
3dd7391
Compare
|
done ;) |
3dd7391 to
333ff4d
Compare
333ff4d to
22888e1
Compare
|
Seems this has been finished for a while. Thanks, I will merge before we get conflicts with @sethtroisi work. |
|
thanks! |
Supersedes #14093
Cleanups many if statements for python>=3.5
cc: @eric-wieser