Thanks to visit codestin.com
Credit goes to github.com

Skip to content

API, DOC: change names to multivariate_hypergeometric, improve docs #15046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2019
Merged

API, DOC: change names to multivariate_hypergeometric, improve docs #15046

merged 2 commits into from
Dec 5, 2019

Conversation

mattip
Copy link
Member

@mattip mattip commented Dec 4, 2019

Address the remaining comments from gh-15007

  • expanding the mvhg naming
  • removing one instance of `random.examples in the docs
  • remove use of private names in the random Cython API documentation

@mattip mattip requested a review from rgommers December 4, 2019 07:41
rgommers
rgommers reviewed Dec 5, 2019
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cython and naming changes LGTM, one final doc tweak comment left.

@rgommers rgommers merged commit 9a79803 into numpy:master Dec 5, 2019
@rgommers
Copy link
Member

rgommers commented Dec 5, 2019

Merged, thanks @mattip!

@rgommers
Copy link
Member

rgommers commented Dec 5, 2019

@charris we'd want this to go into 1.18.0 still

@rgommers rgommers added the 08 - Backport Used to tag backport PRs label Dec 5, 2019
@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 08 - Backport Used to tag backport PRs labels Dec 5, 2019
@charris charris added this to the 1.18.0 release milestone Dec 5, 2019
@charris charris mentioned this pull request Dec 5, 2019
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 5, 2019
@charris charris removed this from the 1.18.0 release milestone Dec 5, 2019
@mattip mattip deleted the random-c-api3 branch November 2, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

@WarrenWeckesser WarrenWeckesser Awaiting requested review from WarrenWeckesser

Assignees
No one assigned
Labels
04 - Documentation 30 - API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattip @rgommers @charris