REV: Revert "Merge pull request #14794 from mattip/nep-0034-impl" #15053
+51
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a prudent course of action, given the magnitude of breakage |
|
For reference, here is a matplotlib PR to deal with some of the issues, and here is a pandas PR |
|
Thanks for the feedback, I've gone ahead and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3a9a63f, reversing
changes made to 7999f7c.
A lot of problems have been exposed by this change, so best to leave it
out of the 1.18.x series and work on it in master. See #15041, #15044,
#15045, #15047, #15051.