MAINT: Do not use private Python function in testing #15203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should make the decorator public and available from |
|
Is this a common problem? |
I doubt it, but when needed it is needed. The memory checks aren't all that different in that regard. Might want to run it by the mailing list for comment. |
|
I think numpy should have some common place for putting private testing
support routines. The memory check decorator was (purposefully) not
added to the public numpy.testing namespace, as I didn't want to
increase the API surface for it.
|
|
Thanks Matti. We should look into @pv 's suggestion of setting up a place for private numpy testing functions. |
|
There is one more numpy/numpy/core/tests/test_regression.py Line 18 in 624d34c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15202
As @pv pointed out, the
testmodule is not to be used outsidestdlibtests. Copy-pasting seems the best idea to resolve this.